Skip to content

ci(NODE-6561): run on matrix of supported node versions #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2024
Merged

ci(NODE-6561): run on matrix of supported node versions #214

merged 4 commits into from
Nov 25, 2024

Conversation

W-A-James
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as draft November 21, 2024 16:37
@W-A-James W-A-James changed the title ci(NODE-6561): run on Node.js 22 ci(NODE-6561): run on matrix of supported node versions Nov 25, 2024
@W-A-James W-A-James marked this pull request as ready for review November 25, 2024 17:11
@baileympearson baileympearson self-assigned this Nov 25, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 25, 2024
@baileympearson baileympearson self-requested a review November 25, 2024 17:32
nbbeeken
nbbeeken reviewed Nov 25, 2024
View reviewed changes
@W-A-James W-A-James requested a review from nbbeeken November 25, 2024 18:40
nbbeeken
nbbeeken approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not review the details but display_name LGTM, ty! (feel free to re-request for team review if it gets there)

@baileympearson baileympearson merged commit 727cc1f into main Nov 25, 2024
17 checks passed
@baileympearson baileympearson deleted the NODE-6561 branch November 25, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@W-A-James @nbbeeken @baileympearson