Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 12, 2025

Description

Summary of Changes

This PR removes callback support from kerberos.

Notes for Reviewers

Some notes on non-obvious changes:

  1. Now that Node20 is our MSNV (minimum supported Node version), we can use fetch in our tests. I adjusted the tests to use fetch, and removed the dependency on request.
  2. After looking over the win32 tests, I determined that they add no additional value. These tests are not testing windows specific functionality and they don't actually run in CI right now. Instead, they execute the mongodb kerberos authentication manually. We have kerberos tests in the driver, and we plan to add better testing on macos and windows in Modernize Kerberos. I chose to remove these tests but will reconsider if the team wants to keep them.

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review September 16, 2025 13:23
@baileympearson baileympearson requested a review from a team as a code owner September 16, 2025 13:23
@durran durran self-assigned this Sep 16, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 16, 2025
@durran durran merged commit 3a5a37f into main Sep 16, 2025
18 checks passed
@durran durran deleted the NODE-6416 branch September 16, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants