feat(NODE-7403): enable more build warnings on Windows#305
Merged
durran merged 1 commit intomongodb-js:mainfrom Jan 27, 2026
Merged
feat(NODE-7403): enable more build warnings on Windows#305durran merged 1 commit intomongodb-js:mainfrom
durran merged 1 commit intomongodb-js:mainfrom
Conversation
rzhao271
force-pushed
the
rzhao271/patch-binding
branch
from
8a8a189 to
87a7ac4
Compare
tadjik1
added
Primary Review
tadjik1
added
Team Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR enables more build warnings on Windows and is a follow-up to #190.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript