ci(NODE-7409): Use CMake's builtin control for the MSVCRT link mode on libmongocrypt

[vector-of-bool]

Description

Summary of Changes

libmongocrypt provided a configuration parameter to control the type of the MSVC runtime library. This parameter was redundant with the control that is offered by CMake already. Prefer instead to use that control.

The parameter, CMAKE_MSVC_RUNTIME_LIBRARY, was added in CMake 3.15, which is the minimum CMake version required by libmongocrypt.

What is the motivation for this change?

We are trying to simplify libmongocrypt's build, which includes removing redundancy with built-in CMake functionality. This specifically is related to MONGOCRYPT-876, which seeks to remove the ENABLE_WINDOWS_STATIC_RUNTIME configuration parameter.

Double check the following

• Lint is passing (npm run check:lint)
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[baileympearson]

@vector-of-bool Looks like windows builds are failing

[vector-of-bool]

The issue appears to be that it's spawning the subprocesss with shell: true and therefore the new angle brackets are being interpreted by cmd.exe as redirection operators.

I can't see in the commit history why shell: process.platform === 'win32' was added here. Does something on Windows require the cmd.exe processor?

I've removed the shell argument for now. If shell: true is required on Windows, there's another option to try in case that fails for some other reason.

[baileympearson]

@vector-of-bool We don't actually know, this is just something we've used in the past to make our tooling work. But that doesn't mean our scripts can't be made to work without it.

Have you tried escaping the angle brackets?

[vector-of-bool]

Angle bracket escaping should be unnecessary if the command is not being interpreted by a shell, so I really don't know why it fails now.

Regardless, the angle bracket magic is not totally necessary and we can just pass MultiThreaded without the Debug suffix.

[tadjik1]

thank you! 👍

[vector-of-bool]

For reference: The shell: true is required on Windows because the scripting executes certain programs that aren't .exe files (e.g. .bat scripts). Using cmd.exe as a command interpreter is required to execute .bat etc. as if they are regular programs.