feat: Add drop-search-index tool #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| protected async execute({ database, collection, indexName }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> { | ||
| const provider = await this.ensureConnected(); | ||
| const result = await provider.dropSearchIndex(database, collection, indexName); |
There was a problem hiding this comment.
nit: Should the tool be a bit smarter and check whether the index exists first? If it doesn't, maybe we notify the LLM? I guess the more context LLM has, the better.
There was a problem hiding this comment.
The provider already checks and returns an error if the index doesn't exist
manoj-pillay-10gen
requested changes
May 13, 2025
| "Deletes a text or vector search index from the database."; | ||
| protected argsShape = { | ||
| ...DbOperationArgs, | ||
| indexName: z.string().describe("The name of the search or vector index to delete"), |
There was a problem hiding this comment.
We'll need to repeat this often, so let's register a
export const SearchIndexOperationArgs = {
database: z.string().describe("Database name"),
collection: z.string().describe("Collection name"),
searchIndexName: z.string().describe("Search or VectorSearch Index Name");
};
in mongodbTool.ts and import it here and use it on L16 and anywhere else we need.
There was a problem hiding this comment.
Done, see 17f9022
| return { | ||
| content: [ | ||
| { | ||
| text: `"Successfully dropped index "${indexName}" from database "${database}"`, |
There was a problem hiding this comment.
nit: looks like we don't need double quotes
`"Successfully - before
`Successfully - after
There was a problem hiding this comment.
Done, see 17f9022
mihirmpatil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add drop-search-index tool
Tested manually with VS code + Copilot and Claude 3.5
Unit/Integration tests will be added in a separate PR