Skip to content

fix: index tests #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

fix: index tests #331

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2751e3
fix: index tests
fmenezes Jun 30, 2025
e4c7c03
fix: style
fmenezes Jun 30, 2025
6e5bd97
fix: tests
fmenezes Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/code_health.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions: {}
jobs:
run-tests:
name: Run MongoDB tests
if: github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
if: github.event_name == 'push' || (github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository)
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Expand All @@ -38,7 +38,7 @@ jobs:

run-atlas-tests:
name: Run Atlas tests
if: github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
if: github.event_name == 'push' || (github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository)
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
Expand All @@ -64,7 +64,7 @@ jobs:

coverage:
name: Report Coverage
if: always() && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
if: always() && (github.event_name == 'push' || (github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository))
runs-on: ubuntu-latest
needs: [run-tests, run-atlas-tests]
steps:
Expand Down
2 changes: 1 addition & 1 deletion src/tools/mongodb/read/aggregate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
// Check if aggregate operation uses an index if enabled
if (this.config.indexCheck) {
await checkIndexUsage(provider, database, collection, "aggregate", async () => {
return provider

Check failure on line 31 in src/tools/mongodb/read/aggregate.ts

View workflow job for this annotation

GitHub Actions / check-style 

Replace `⏎····················.aggregate(database,·collection,·pipeline)⏎····················` with `.aggregate(database,·collection,·pipeline)`
.aggregate(database, collection, pipeline, {}, { writeConcern: undefined })
.aggregate(database, collection, pipeline)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main fix

.explain("queryPlanner");
});
}
Expand Down
1 change: 1 addition & 0 deletions tests/integration/tools/mongodb/mongodbHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export function setupMongoDBIntegrationTest(): MongoDBIntegrationTest {
tmpDir: dbsDir,
logDir: path.join(tmpDir, "mongodb-runner", "logs"),
topology: "standalone",
version: "8.0.10",
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment to clarify why MongoDB version 8.0.10 is hard-coded here or parameterize it for future flexibility.

Suggested change
version: "8.0.10",
version: DEFAULT_MONGODB_VERSION,

Copilot uses AI. Check for mistakes.

});

return;
Expand Down
Loading