Skip to content

chore: specify the correct minimum node requirements #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

chore: specify the correct minimum node requirements #378

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8eebd2a
chore: specify the correct node requirements
himanshusinghs Jul 16, 2025
7896c9c
chore: clarify node requirements in readme
himanshusinghs Jul 17, 2025
26da86b
chore: format fix
himanshusinghs Jul 17, 2025
2f2bcf3
package-lock update
himanshusinghs Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,6 @@
"zod": "^3.25.76"
},
"engines": {
"node": ">=20.19.0"
"node": "^20.19.0 || ^22.12.0 || >= 23.0.0"
Copy link

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint syntax is inconsistent. The third range uses '>= 23.0.0' while the first two use caret ranges (^). Consider using '^23.0.0' for consistency, or if you specifically need all v23+ versions, document why this range differs from the others.

Suggested change
"node": "^20.19.0 || ^22.12.0 || >= 23.0.0"
"node": "^20.19.0 || ^22.12.0 || ^23.0.0"

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions >= 23.0.0 support requiring esm by default

}
}
Loading