chore: use pull_request_target for dependabot prs #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the GitHub workflow trigger for Dependabot PRs from pull_request to pull_request_target to enable access to repository secrets that Dependabot requires.
- Changes workflow event trigger to allow Dependabot access to repository secrets
- Maintains the same event types and branch filtering configuration
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| name: Dependabot PR | |||
| on: | |||
| pull_request: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
Using pull_request_target creates a security risk as it runs workflows in the context of the target repository with access to secrets, even for external contributors. Consider adding explicit checks to verify the PR author is Dependabot (e.g., if: github.actor == 'dependabot[bot]') to prevent potential code injection attacks from malicious PRs.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
We already do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Dependabot doesn't have access to repo secrets, which is why we must use
pull_request_targetevent trigger.