Skip to content

chore: refactor connections to use the new ConnectionManager to isolate long running processes like OIDC connections MCP-81 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 6, 2025
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3977aa7
chore: refactor to include the new ConnectionManager
kmruiz Aug 4, 2025
7a1e217
chore: add tests to connection manager
kmruiz Aug 5, 2025
ece4d6c
chore: fix typo
kmruiz Aug 5, 2025
06a7ea8
chore: js prefers strict equality
kmruiz Aug 5, 2025
806382f
chore: fix linter errors
kmruiz Aug 5, 2025
4c357f9
chore: connection requested is not necessary at the end
kmruiz Aug 5, 2025
3f52815
chore: add test to connection-requested
kmruiz Aug 5, 2025
28d8b69
chore: add tests for the actual connection status
kmruiz Aug 6, 2025
f7ec158
chore: Fix typing issues and few PR suggestions
kmruiz Aug 6, 2025
f49e2b0
chore: style changes, use a getter for isConnectedToMongoDB
kmruiz Aug 6, 2025
e03b7a6
chore: move AtlasConnectionInfo to the connection manager
kmruiz Aug 6, 2025
43b54a0
chore: fixed linting issues
kmruiz Aug 6, 2025
89ba76d
chore: emit the close event
kmruiz Aug 6, 2025
61d7b1e
chore: add resource subscriptions and improve the resource prompt
kmruiz Aug 6, 2025
a33abb3
chore: Do not use anonymous tuples
kmruiz Aug 6, 2025
cc92766
chore: change the break to a return to make it easier to follow
kmruiz Aug 6, 2025
0a77b97
chore: small refactor
kmruiz Aug 6, 2025
6b5f49b
chore: minor clean up of redundant params
kmruiz Aug 6, 2025
6cbb1ab
Merge branch 'main' into chore/mcp-81
kmruiz Aug 6, 2025
1122e09
chore: ensure that we return connecting when not connected yet
kmruiz Aug 6, 2025
da872b4
chore: allow having the atlas cluster info independently of the conne…
kmruiz Aug 6, 2025
fe16acd
chore: simplify query connection logic
kmruiz Aug 6, 2025
17494ac
chore: This is clearer on how the behavior should look like
kmruiz Aug 6, 2025
693c755
chore: finish the refactor and clean up
kmruiz Aug 6, 2025
a6efc47
chore: propagate connected atlas cluster when disconnecting
kmruiz Aug 6, 2025
71dbf56
chore: fix linter issues and some status mismatch
kmruiz Aug 6, 2025
76e8ab5
chore: clean up atlas resource handling
kmruiz Aug 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/atlas/connect/connectCluster.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class ConnectClusterTool extends AtlasToolBase {
return "connected-to-other-cluster";
}

if (!this.session.isConnectedToMongoDB) {
if (this.session.connectionManager.currentConnectionState.tag !== "connected") {
return "connecting";
}

Expand Down
Loading