chore: refactor package.json import #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
commented
Apr 10, 2025
nirinchev
reviewed
Apr 10, 2025
|
|
||
| const packageMetadata = fs.readFileSync(path.join(__dirname, "..", "package.json"), "utf8"); | ||
| const packageJson = JSON.parse(packageMetadata); | ||
| import packageJson from "../package.json" with { type: "json" }; |
There was a problem hiding this comment.
Does this work on windows?
There was a problem hiding this comment.
I haven't tested anything on windows yet, perhaps we should start with integration tests and run them on linux, windows and macos
nirinchev
approved these changes
Apr 10, 2025
gagik
requested changes
Apr 10, 2025
@gagik I've enabled it but in the case of |
gagik
approved these changes
Apr 10, 2025
nirinchev
added a commit
that referenced
this pull request
Apr 10, 2025
* main: chore: refactor package.json import (#43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.