Skip to content

Conversation

kmruiz
Copy link
Collaborator

@kmruiz kmruiz commented Aug 25, 2025

Proposed changes

This adds more information to the debug resource whenever there is an issue connecting.

Checklist

This adds more information to the debug resource whenever there is
an issue connecting.
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 16:07
@kmruiz kmruiz requested a review from a team as a code owner August 25, 2025 16:07
@kmruiz kmruiz self-assigned this Aug 25, 2025
Copilot

This comment was marked as outdated.

@kmruiz kmruiz requested a review from Copilot August 27, 2025 11:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error reporting when MongoDB connections fail by adding more detailed information to debug resources. The changes improve the debugging experience by providing authentication mechanism details and Atlas cluster information when connection errors occur.

Key changes:

  • Updated connection error events to include structured error information instead of simple error strings
  • Added authentication type inference and Atlas cluster details to error reporting
  • Enhanced debug resource output to display inferred authentication mechanisms and Atlas cluster information

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/common/connectionManager.ts Added connection string auth type inference and structured error reporting
src/common/session.ts Updated event handlers to pass complete error objects instead of just error messages
src/resources/common/debug.ts Enhanced debug output to display authentication type and Atlas cluster information
tests/unit/resources/common/debug.test.ts Updated tests to verify new structured error information display
tests/integration/common/connectionManager.test.ts Added integration tests for Atlas cluster connection failure scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coveralls
Copy link
Collaborator

coveralls commented Aug 27, 2025

Pull Request Test Coverage Report for Build 17269549497

Details

  • 26 of 27 (96.3%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 81.92%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/resources/common/debug.ts 16 17 94.12%
Totals Coverage Status
Change from base Build 17268043086: 0.06%
Covered Lines: 4435
Relevant Lines: 5395

💛 - Coveralls

Copy link
Collaborator

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a question for better understanding.

@kmruiz kmruiz merged commit a06b443 into main Aug 28, 2025
15 of 17 checks passed
@kmruiz kmruiz deleted the chore/mcp-92 branch August 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants