fix: add a ping loop for http transport clients #484
Merged
+45
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
force-pushed
the
ni/http-pings
branch
from
48207f3 to
f54b86f
Compare
nirinchev
commented
Aug 28, 2025
src/transports/streamableHttp.ts
Outdated
|
|
||
| if (++failedPings > 3) { | ||
| clearInterval(keepAliveLoop); | ||
| await transport.close(); |
There was a problem hiding this comment.
This needs to be in a try-catch
There was a problem hiding this comment.
Pull Request Overview
This PR implements a heartbeat mechanism for HTTP transport clients by adding a ping loop that sends periodic pings every 30 seconds to maintain connection liveness. The implementation closes the transport after 3 consecutive failed ping attempts.
- Adds ping loop functionality with 30-second intervals and failure tracking
- Introduces new log IDs for ping operations and failures
- Updates error message formatting and logging for better debugging
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/transports/streamableHttp.ts | Implements the main ping loop logic with keepalive interval and transport closure after failed pings |
| src/index.ts | Enhances error logging in server close handler with error details |
| src/common/logger.ts | Adds new log IDs for ping operations and failures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This makes it so the server sends a ping every 30 seconds to connected clients to ensure the connection is still alive. After 3 failed pings, we close the transport.
Checklist