Skip to content

chore: add some extra log level validations #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

chore: add some extra log level validations #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export class DiskLogger extends LoggerBase<{ initialized: [] }> {
}

export class McpLogger extends LoggerBase {
private static readonly LOG_LEVELS: LogLevel[] = [
public static readonly LOG_LEVELS: LogLevel[] = [
"debug",
"info",
"notice",
Expand All @@ -259,7 +259,7 @@ export class McpLogger extends LoggerBase {
"critical",
"alert",
"emergency",
];
] as const;

public constructor(private readonly server: Server) {
super();
Expand Down
6 changes: 5 additions & 1 deletion src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { AtlasTools } from "./tools/atlas/tools.js";
import { MongoDbTools } from "./tools/mongodb/tools.js";
import { Resources } from "./resources/resources.js";
import type { LogLevel } from "./common/logger.js";
import { LogId } from "./common/logger.js";
import { LogId, McpLogger } from "./common/logger.js";
import type { Telemetry } from "./telemetry/telemetry.js";
import type { UserConfig } from "./common/config.js";
import { type ServerEvent } from "./telemetry/types.js";
Expand Down Expand Up @@ -107,6 +107,10 @@ export class Server {
});

this.mcpServer.server.setRequestHandler(SetLevelRequestSchema, ({ params }) => {
if (!McpLogger.LOG_LEVELS.includes(params.level)) {
throw new Error(`Invalid log level: ${params.level}`);
}

this._mcpLogLevel = params.level;
return {};
});
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/logger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import * as path from "path";
import * as fs from "fs/promises";
import { once } from "events";
import type { Server } from "../../src/server.js";
import { LoggingMessageNotificationSchema } from "@modelcontextprotocol/sdk/types.js";

describe("Logger", () => {
let consoleErrorSpy: MockInstance<typeof console.error>;
Expand Down Expand Up @@ -332,5 +333,9 @@ describe("Logger", () => {
expect(mcpLoggerSpy).toHaveBeenCalledTimes(2);
expect(getLastMcpLogMessage()).toContain("Alert message");
});

it("MCPLogger.LOG_LEVELS contains all possible levels", () => {
expect(McpLogger.LOG_LEVELS).toEqual(LoggingMessageNotificationSchema.shape.params.shape.level.options);
});
});
});
Loading