Skip to content

fix: allow connect tool on readOnly mode #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

fix: allow connect tool on readOnly mode #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2dcad3
fix: allow connect tool on readOnly mode
blva Sep 1, 2025
65e2e1b
fix: increase mxIdleTimeMS in oidcConfig
blva Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export abstract class ToolBase {
let errorClarification: string | undefined;

// Check read-only mode first
if (this.config.readOnly && !["read", "metadata"].includes(this.operationType)) {
if (this.config.readOnly && !["read", "metadata", "connect"].includes(this.operationType)) {
errorClarification = `read-only mode is enabled, its operation type, \`${this.operationType}\`,`;
} else if (this.config.disabledTools.includes(this.category)) {
errorClarification = `its category, \`${this.category}\`,`;
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/common/connectionManager.oidc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ describe.skipIf(process.platform !== "linux")("ConnectionManager OIDC Tests", as
...defaultTestConfig,
oidcRedirectURi: "http://localhost:0/",
authenticationMechanism: "MONGODB-OIDC",
maxIdleTimeMS: "1",
maxIdleTimeMS: "10000",
minPoolSize: "0",
username: "testuser",
browser: fetchBrowserFixture,
Expand Down
Loading