feat(atlas-local): Added Atlas Local List Deployments tool #520
Conversation
jeroenvervaeke
force-pushed
the
MCP-158
branch
from
8370208 to
e6b0d15
Compare
src/server.ts
Outdated
| this.registerToolInstances(AtlasLocalTools); | ||
| } catch (error) { | ||
| // If Atlas Local tools are disabled, don't log an error | ||
| if (this.userConfig.disabledTools.includes("atlas-local")) { |
There was a problem hiding this comment.
Shouldn't this be done even before the import at line 207? Why do we want to attempt this if the tools are disabled? Or am I missing something?
There was a problem hiding this comment.
Good point, I missed this. Updated
| const client = AtlasLocalClient.connect(); | ||
|
|
||
| // Set Atlas Local client | ||
| this.session.setAtlasLocalClient(client); |
There was a problem hiding this comment.
for streamable http, we'll have multiple sessions that will connect to the server and manage the local atlas env, do we think this is the best place to add set client or should we set it somewhere else? if you think we need a single client, you could check the transport file base.ts and how we inject DeviceId (long-running operation that blocks other calls) or Telemetry
There was a problem hiding this comment.
It is ok to have multiple instances of the client, it should not cause any issues
|
Could we also decouple the atlas local tests? in |
Proposed changes
Ticket: [MCP-158] [mongodb-mcp-server] Implement listLocalAtlasClusters tool
Checklist