chore: add isError annotation for handled errors #623
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshusinghs
added
the
no-title-validation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing isError: true annotations to error response objects in MongoDB tools to ensure proper error handling consistency across the codebase.
Key changes:
- Adds
isError: trueannotation to error responses in three MongoDB tools - Ensures consistent error handling patterns across collection-related operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/mongodb/update/renameCollection.ts | Added isError: true to "NamespaceNotFound" and "NamespaceExists" error cases |
| src/tools/mongodb/read/collectionIndexes.ts | Added isError: true to collection not found error case |
| src/tools/mongodb/metadata/collectionStorageSize.ts | Added isError: true to collection not found error case |
gagik
approved these changes
Oct 8, 2025
blva
approved these changes
Oct 8, 2025
nirinchev
approved these changes
Oct 8, 2025
Pull Request Test Coverage Report for Build 18342327970Details
💛 - Coveralls |
cveticm
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds
isErrorannotation for handled errors that were missed.Checklist