feat: internal to Expanded JSON Schema conversion COMPASS-8702 #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
force-pushed
the
COMPASS-8702-2
branch
from
53b184d to
0956982
Compare
Anemy
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
lgtm!
One thing around sample values that maybe we could do is add some tests around outliers that would test performance. Like really long strings, really long arrays, tons of fields, or something. Probably nothing to do here, it's more related to how we're doing the internal schema, it's something worth thinking about in the future I reckon.
|
😂 you're already thinking about what I just left a comment for re #221 |
Yes, we already had the cropping for string in the analysis, so I'm just adding some extra cropping in the same place. And big arrays or complex documents will be covered by https://jira.mongodb.org/browse/COMPASS-8905 |
paula-stacho
merged commit bb683be
into
COMPASS-6862-schema-export-multiple-formats
18 checks passed
paula-stacho
added a commit
that referenced
this pull request
Feb 6, 2025
…S-8702 COMPASS-8709 (#222) * feat: add analyzeDocuments + SchemaAccessor COMPASS-8799 (#216) --------- Co-authored-by: Anna Henningsen <[email protected]> * feat: internal to MongoDB $jsonSchema conversion COMPASS-8701 (#218) --------- Co-authored-by: Anna Henningsen <[email protected]> * feat: internal to Standard JSON Schema conversion COMPASS-8700 (#219) * feat: internal to Expanded JSON Schema conversion COMPASS-8702 (#220) --------- Co-authored-by: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last piece of the puzzle, we're generating expanded JSON Schema.
Differences from the JSON Schema:
x-bsonTypealong thetype(using the same map as we have for$jsonSchema)x-metaDataandx-sampleValues(these are taken from the internal schema)Notes: metadata (count, probability, hasDuplicates) are present both on the type and field level in the internal schema. I kept this. Sample values are present on the type level and are not present in objects/arrays in the internal schema, so again we're just taking them when they're available.