feat: optional field count threshold #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
lgtm.
One thing that does come to mind is that with the new interface and options, the README of this github repo is still only showing the old way of parsing the schema. I don't think we need to do it now, however if we feel more folks are going to try it out we could spend some time to improve that documentation.
| @@ -167,6 +167,7 @@ type AllSchemaParseOptions = { | |||
| storeValues: boolean; | |||
| signal?: AbortSignal; | |||
| storedValuesLengthLimit: number; | |||
| distinctFieldsAbortThreshold?: number; | |||
There was a problem hiding this comment.
I like the naming, one thing we could do is add a description here if we feel the name doesn't fully encapsulate it's usage and intention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again an optional parameter. I had hard time coming up with the name, let me know if you have better suggestion. This one is a hard limit that can be imposed on the complexity (represented by unique field count). Together with the lower stored samples limit, it can be used as a prevention mechanism for running out of memory during the analysis itself (https://jira.mongodb.org/browse/COMPASS-8526), or later down the line (such as the new schema export conversion or file download).