chore(ci): Increase timeout to stabilize e2e tests on MacOS x64 #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
Sep 16, 2024
Comment on lines
+178
to
+211
| await eventually( | ||
| () => { | ||
| const output = this._output.slice(start); | ||
| const lines = output.split('\n'); | ||
| const found = !!lines | ||
| .filter((l) => PROMPT_PATTERN.exec(l)) // a line that is the prompt must at least match the pattern | ||
| .find((l) => { | ||
| // in some situations the prompt occurs multiple times in the line (but only in tests!) | ||
| const prompts = l | ||
| .trim() | ||
| .replace(/>$/g, '') | ||
| .split('>') | ||
| .map((m) => m.trim()); | ||
| // if there are multiple prompt parts they must all equal | ||
| if (prompts.length > 1) { | ||
| for (const p of prompts) { | ||
| if (p !== prompts[0]) { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return true; | ||
| }); | ||
| if (!found) { | ||
| throw new assert.AssertionError({ | ||
| message: 'expected prompt', | ||
| expected: PROMPT_PATTERN.toString(), | ||
| actual: | ||
| this._output.slice(0, start) + | ||
| '[prompt search starts here]' + | ||
| output, | ||
| }); | ||
| return true; | ||
| }); | ||
| if (!found) { | ||
| throw new assert.AssertionError({ | ||
| message: 'expected prompt', | ||
| expected: PROMPT_PATTERN.toString(), | ||
| actual: | ||
| this._output.slice(0, start) + | ||
| '[prompt search starts here]' + | ||
| output, | ||
| }); | ||
| } | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
All the above are merely a result of husky running prettier
addaleax
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to stabilize the test failures of the
e2e_tests_darwin_x64task.