Skip to content

chore(deps): Add node-gyp version control across different distros MONGOSH-1891 #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gagik merged 17 commits into from
Oct 23, 2024
Merged

chore(deps): Add node-gyp version control across different distros MONGOSH-1891 #2230

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5b48842
Bump node-gyp
gagik Oct 21, 2024
7092699
Try an override?
gagik Oct 21, 2024
abf767d
Try or version
gagik Oct 21, 2024
5b6caee
remove node condition
gagik Oct 21, 2024
3e4b3a4
check distro id
gagik Oct 22, 2024
b219d69
move to compile-artifact
gagik Oct 22, 2024
ac9629f
pass distro_id
gagik Oct 22, 2024
e0d6734
export before source
gagik Oct 22, 2024
7ecd9eb
pass it in task commands
gagik Oct 22, 2024
04aa11e
Move back to install-npm-deps.sh
gagik Oct 22, 2024
b083776
Install gyp before rest
gagik Oct 22, 2024
adb320a
use npm i
gagik Oct 22, 2024
8557533
Try without replace
gagik Oct 22, 2024
8d16108
Keep only needed changes
gagik Oct 22, 2024
54a4d25
Merge branch 'main' into gagik/chore-bump-gyp
gagik Oct 22, 2024
7908210
Add ubuntu1804
gagik Oct 23, 2024
d2a3e3f
Add better comment
gagik Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .evergreen/install-npm-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ if [[ -n "$MONOGDB_DRIVER_VERSION_OVERRIDE" ]]; then
npm i --verbose --force
fi

# Needed to ensure Python 3.6 support which is the oldest one that's available out-of-the-box on the rhel70 hosts.
if [[ "${DISTRO_ID}" =~ ^(rhel7) ]] && [[ "$NODE_JS_VERSION" =~ ^20 ]]; then
export REPLACE_PACKAGE="node-gyp:9.0.0"
npm run replace-package

npm i --verbose --force
fi

# if we rewrote this script in javascript using just builtin node modules we could skip the npm ci above
npm run mark-ci-required-optional-dependencies

Expand All @@ -30,4 +38,4 @@ npm run mark-ci-required-optional-dependencies
npm run evergreen-release bump

echo "npm packages after installation"
npm ls || true
npm ls || true
Loading
Loading