Skip to content

Conversation

@gagik
Copy link
Contributor

@gagik gagik commented Nov 4, 2024

Following https://github.com/10gen/mothra/pull/1196, we should be able to use Foliage.

This is largely replicating changes done in mongodb-js/compass#6168.

Unfortunately we can't really test this without putting it in main first as Foliage doesn't file tickets for failures in patches. It files them based on mainline commits.

Only worry I have right now is that because of our setup we might end up with a spam of test failures for a task on every platform if 1 test fails across all of them

@gagik gagik changed the title WIP: Add Foliage support chore: add support for Foliage ticket filing MONGOSH-1869 Nov 4, 2024
@gagik gagik marked this pull request as ready for review November 4, 2024 14:05
@gagik gagik changed the title chore: add support for Foliage ticket filing MONGOSH-1869 chore(ci): add support for Foliage ticket filing MONGOSH-1869 Nov 4, 2024
@gagik gagik requested a review from addaleax November 4, 2024 14:05
<% for (const { id, nShort, nVersion, mShort, mVersion, skipNodeVersionCheck, packageName } of ALL_UNIT_TESTS) { %>
- name: test_<% out(id) %>
tags: <% out(["unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %>
tags: <% out(["assigned_to_jira_team_mongosh_mongosh", "unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %>
Copy link
Contributor Author

@gagik gagik Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also foliage_check_task_only which will create tickets for the whole task instead of a specific test failure but I think we should be fine regardless?

only worry I have right now is that because of our setup we might end up with a spam of test failures for a task on every platform if 1 test fails across all of them

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah, I can see your concern ... but our task names already include platform names, I guess making it a per-task thing wouldn't actually help all that much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is basically unavoidable without refactoring our tasks a lot more, we could just put it in and see what happens I suppose

<% for (const { id, nShort, nVersion, mShort, mVersion, skipNodeVersionCheck, packageName } of ALL_UNIT_TESTS) { %>
- name: test_<% out(id) %>
tags: <% out(["unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %>
tags: <% out(["assigned_to_jira_team_mongosh_mongosh", "unit-test", ...(mShort === 'latest' ? ["mlatest"] : [])]) %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah, I can see your concern ... but our task names already include platform names, I guess making it a per-task thing wouldn't actually help all that much?

@gagik gagik marked this pull request as draft November 14, 2024 13:44
@gagik gagik marked this pull request as ready for review November 15, 2024 11:32
@gagik
Copy link
Contributor Author

gagik commented Nov 15, 2024

Merging this as that is the only way to really test Foliage and should hopefully be useful enough for now. Created MONGOSH-1907 for a future follow-up with E2E tests.

@gagik gagik merged commit 331149a into main Nov 15, 2024
107 of 144 checks passed
@gagik gagik deleted the gagik/add-foliage branch November 15, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants