chore(ci): set MACOSX_DEPLOYMENT_TARGET
#2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in semantics, but the environment variable is generally replacing the `-mmacosx-version-min` compiler flag, so let's specify both. (We could raise the minimum as well at some point, but unless there's an actual reason to do so other than "we can" I'd just leave it as-is.)
addaleax
added
the
no-title-validation
nirinchev
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change in semantics, but the environment variable is generally replacing the
-mmacosx-version-mincompiler flag, so let's specify both.(We could raise the minimum as well at some point, but unless there's an actual reason to do so other than "we can" I'd just leave it as-is.)