Skip to content

fix(browser-repl): use an error background color that makes syntax highlighting legible COMPASS-8308 MONGOSH-1974 #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djechlin-mongodb merged 2 commits into from
Dec 20, 2024
Merged

fix(browser-repl): use an error background color that makes syntax highlighting legible COMPASS-8308 MONGOSH-1974 #2307

djechlin-mongodb merged 2 commits into from
Dec 20, 2024

Conversation

@djechlin-mongodb
Copy link
Contributor

@djechlin-mongodb djechlin-mongodb commented Dec 19, 2024 •
edited
Loading

These changes are requested by design:

  1. The light red background should remain the darker background.
  2. The initial error declaration should be light red not dark red.
  3. The first line of the error, and the initial text, should be white.
  4. There should be a light red indent bar (in css, a left border) to the left of the stack.

New, better:

image

Old, worse:

image

@djechlin-mongodb djechlin-mongodb marked this pull request as ready for review December 19, 2024 23:03
@djechlin-mongodb djechlin-mongodb merged commit 0919d39 into main Dec 20, 2024
129 of 137 checks passed
@djechlin-mongodb djechlin-mongodb deleted the COMPASS-8308 branch December 20, 2024 18:44
@djechlin-mongodb djechlin-mongodb changed the title fix(browser-repl): use an error background color that makes syntax highlighting legible COMPASS-8308 fix(browser-repl): use an error background color that makes syntax highlighting legible COMPASS-8308 MONGOSH-1974 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lerouxb lerouxb lerouxb approved these changes

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djechlin-mongodb @lerouxb @addaleax