chore(release): use a different release process when publishing auxiliary packages #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
added
the
no-title-validation
gagik
force-pushed
the
gagik/different-release-path
branch
from
2a4aa5b to
d17b88f
Compare
addaleax
approved these changes
Jan 15, 2025
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Only small bit of feedback I'd have is that the commit message here could be used to explain what didn't work with the previous approach/how exactly this approach differs from it 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring to make it different scenarios clearer and use a different function when just publishing auxiliary packages.
We should just be publishing to npm in this case (and let lerna push tags).