Skip to content

fix(ci): add publishing tags step when publishing auxiliary packages MONGOSH-1871 #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gagik merged 5 commits into from
Jan 28, 2025
Merged

fix(ci): add publishing tags step when publishing auxiliary packages MONGOSH-1871 #2332

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0a051c
fix(ci): add publishing tags step when publishing auxiliary packages
gagik Jan 27, 2025
de6927b
feat(ci): add pushTags function instead of script for pushing tags
gagik Jan 28, 2025
e9e09cd
feat(ci): add temporary workflow to push auxiliary tags
gagik Jan 28, 2025
0f85b12
fix: pin bot token setup to a commit hash
gagik Jan 28, 2025
8014b75
fix: correct typos in configurations
gagik Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/publish-auxiliary-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,10 @@ jobs:
npm config list
echo "Publishing packages as $(npm whoami)"
npm run publish-auxiliary

- name: "Publish tags"
Copy link
Contributor Author

@gagik gagik Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

essentially same as https://github.com/mongodb-js/compass/blob/main/.github/workflows/publish-packages.yaml#L60 with one adjustment to not push tags for mongosh in this case

run: |
npx lerna list -a --json | \
jq -r '.[] | select(.name != "mongosh") | .name + "@" + .version' | \
Copy link
Collaborator

@addaleax addaleax Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mongosh excluded here because it's not scoped with @mongosh/? Maybe add a comment or even a test somewhere that reminds people to update this line if that ever changes

Copy link
Contributor Author

@gagik gagik Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am excluding it here as it is the publishing auxiliary packages which would mean it'd try to publish mongosh@x.x.x multiple times and make the tag meaningless.

Come to think of it, it'd be trivial to extract this to a function as well and make this distinction easier to reason about (and test/enforce) so I'll do that. It'd be a good test for the release git run also as I'm not 100% on how well it can access git.

xargs -i sh -c "git tag -a {} -m {} || true"
git push --follow-tags
Loading