feat(cli-repl): add configuration to set max log files size MONGOSH-1985#2361
Merged
feat(cli-repl): add configuration to set max log files size MONGOSH-1985#2361
Conversation
gagik
force-pushed
the
gagik/add-log-retention-file-size
branch
2 times, most recently
from
e6e9338 to
a39adef
Compare
gagik
force-pushed
the
gagik/add-log-retention-file-count
branch
2 times, most recently
from
dc47df4 to
9a0b368
Compare
gagik
force-pushed
the
gagik/add-log-retention-file-size
branch
from
a39adef to
0aec4d5
Compare
addaleax
reviewed
Feb 7, 2025
Contributor
Author
|
On the topic of unexpected green CI, https://github.com/mongodb-js/mongosh/actions/runs/13199134044/job/36846954054?pr=2361 seems not to actually run tests? Edit: created MONGOSH-2011 |
gagik
force-pushed
the
gagik/add-log-retention-file-count
branch
3 times, most recently
from
5f2ec09 to
a265439
Compare
gagik
force-pushed
the
gagik/add-log-retention-file-size
branch
2 times, most recently
from
96dbf08 to
82bdc5d
Compare
gagik
force-pushed
the
gagik/add-log-retention-file-size
branch
from
54df0a1 to
70ce60b
Compare
addaleax
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires mongodb-js/devtools-shared#504 to be released.
Builds on top of #2354