chore(ci): don't use gcc on macOS MONGOSH-2029 #2390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
changed the title
nirinchev
changed the title
addaleax
approved these changes
Feb 28, 2025
| (which gcc && gcc --version) | ||
|
|
||
| echo "Using g++ version:" | ||
| (which g++ && g++ --version) |
Collaborator
There was a problem hiding this comment.
Can we still print the compiler versions in the darwin case?
gagik
approved these changes
Feb 28, 2025
addaleax
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc is not officially supported on macOS (per Build Platform Support Tiers) and would typically not be installed, which is why the scripts have worked previously. It appears that there was a rogue task that installed the linux toolchain on those macs and is currently being removed. Still, I think the changes in this PR make sense as a way to protect us against future incidents.