chore(ci): don't download chrome in bump-auxiliary-packages#2391
Merged
chore(ci): don't download chrome in bump-auxiliary-packages#2391
Conversation
nirinchev
commented
Mar 3, 2025
Comment on lines
-44
to
-45
| git add . | ||
| git commit --no-allow-empty -m "chore(release): bump packages for auxiliary release" || true |
Collaborator
Author
There was a problem hiding this comment.
peter-evans/create-pull-request already commits all changes, so there's no reason for us to manually do it.
gagik
approved these changes
Mar 4, 2025
Contributor
gagik
left a comment
gagik
left a comment
There was a problem hiding this comment.
LGTM, can probably be extended to the publish workflow also
| contents: none # We use the github app to checkout and create PR | ||
|
|
||
| env: | ||
| PUPPETEER_SKIP_DOWNLOAD: "true" |
Contributor
There was a problem hiding this comment.
oh nice, same can be applied to publish-auxiliary-packages.yml
nirinchev
added
the
no-title-validation
gagik
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change that sets the
PUPPETEER_SKIP_DOWNLOADenvironment variable inbump-auxiliary-packages.ymlas we don't really need chrome there. Additionally, it adds a description for the workflow and removes some redundant committing.