feat(shell-api): add sh.isConfigShardEnabled and listShards helpers MONGOSH-1919#2400
Merged
feat(shell-api): add sh.isConfigShardEnabled and listShards helpers MONGOSH-1919#2400
Conversation
nirinchev
changed the title
addaleax
changed the title
addaleax
approved these changes
Mar 6, 2025
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Looks good!
Makes me wonder though, do we also want to expose a generic sh.listShards() helper that forwards to adminCommand({ listShards: 1 })? That feels like something that should be there in some form, no?
Collaborator
Author
|
Yeah - was a bit surprised that it wasn't there already, but figured perhaps it was simple enough that nobody requested it 🤷♂️ Happy to add it though - seems useful enough to justify having some autocompletion. |
nirinchev
changed the title
Collaborator
Author
|
ping @addaleax - I know you approved the PR, but I did end up adding a |
addaleax
approved these changes
Mar 11, 2025
| 1 | ||
| ); | ||
| expect((await sh.status()).value.shards[0].tags).to.deep.equal([]); | ||
| expect((await sh.listShards())[0].tags).to.deep.equal([]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
sh.isConfigShardEnabledhelper for server versions 8.0 and above. It useslistShardsand then looks for a shard with_id: 'config'.Additionally, it adds the
sh.listShardshelper that calls thelistShardsadmin command.