Conversation
gagik
reviewed
Apr 7, 2025
.evergreen/setup-env.sh
Outdated
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" | ||
| set +x # nvm is very verbose | ||
| echo nvm use $NODE_JS_VERSION || nvm use 20.11.1 | ||
| nvm use $NODE_JS_VERSION || nvm use 20.11.1 # see install-node.sh |
Contributor
There was a problem hiding this comment.
Suggested change
| nvm use $NODE_JS_VERSION || nvm use 20.11.1 # see install-node.sh | |
| # Node.js 20.11.1 is the last 20.x that builds out of the box on RHEL7 | |
| # https://github.com/nodejs/node/issues/52223 | |
| nvm use $NODE_JS_VERSION || nvm use 20.11.1 |
(since we remove this comment otherwise; though not sure how relevant it still is)
Collaborator
Author
There was a problem hiding this comment.
Yeah, great catch, we can actually remove the fallback here altogether since we only use nvm on macOS now: 745915d
gagik
approved these changes
Apr 7, 2025
Contributor
gagik
left a comment
gagik
left a comment
There was a problem hiding this comment.
Nice, will be great to have the quicker CI 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.