Skip to content

[WIP] use mql #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP] use mql #2478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d6cb8a
use mql
lerouxb Jun 18, 2025
8c763d6
wip
lerouxb Jun 19, 2025
a17eef1
fixup: update package lock
addaleax Jun 19, 2025
07ee31d
update mql
lerouxb Jun 19, 2025
fa959f4
WIP
lerouxb Jun 24, 2025
9698f5b
fixup: improve types a bit
addaleax Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configs/tsconfig-mongosh/tsconfig.common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"removeComments": true,
"target": "es2018",
"lib": ["es2019"],
"module": "commonjs",
"moduleResolution": "node"
"module": "node16",
"moduleResolution": "node16"
}
}
2 changes: 1 addition & 1 deletion packages/autocomplete/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"dependencies": {
"@mongodb-js/mongodb-constants": "^0.10.1",
"@mongosh/shell-api": "^3.13.0",
"@mongodb-js/mongodb-ts-autocomplete": "^0.2.5",
"@mongodb-js/mongodb-ts-autocomplete": "^0.3.1",
"semver": "^7.5.4"
}
}
2 changes: 1 addition & 1 deletion packages/browser-runtime-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@mongodb-js/eslint-config-mongosh": "^1.0.0",
"@mongodb-js/prettier-config-devtools": "^1.0.1",
"@mongodb-js/tsconfig-mongosh": "^1.0.0",
"@mongodb-js/mongodb-ts-autocomplete": "^0.2.5",
"@mongodb-js/mongodb-ts-autocomplete": "^0.3.1",
"@mongosh/types": "3.8.0",
"bson": "^6.10.3",
"depcheck": "^1.4.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
},
"dependencies": {
"@mongodb-js/devtools-github-repo": "^1.4.2",
"@mongodb-js/dl-center": "^1.3.0",
"@mongodb-js/dl-center": "^1.4.1",
"@mongodb-js/mongodb-downloader": "^0.3.7",
"@mongodb-js/monorepo-tools": "^1.1.16",
"@mongodb-js/signing-utils": "^0.3.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/download-center/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { major as majorVersion } from 'semver';
import type {
DownloadCenterConfig,
PlatformWithPackages,
} from '@mongodb-js/dl-center/dist/download-center-config';
} from '@mongodb-js/dl-center';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new module resolution compiler option is not liking the /dist/ hack so I changed @mongodb-js/dl-center to just export the types.

import {
ARTIFACTS_BUCKET,
ARTIFACTS_BUCKET_NEW,
Expand Down
3 changes: 2 additions & 1 deletion packages/shell-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
"devDependencies": {
"@microsoft/api-extractor": "^7.39.3",
"@mongodb-js/eslint-config-mongosh": "^1.0.0",
"@mongodb-js/mongodb-ts-autocomplete": "^0.2.5",
"@mongodb-js/mongodb-ts-autocomplete": "^0.3.1",
"@mongodb-js/mql-typescript": "^0.2.1",
"@mongodb-js/prettier-config-devtools": "^1.0.1",
"@mongodb-js/tsconfig-mongosh": "^1.0.0",
"@mongosh/types": "3.8.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/shell-api/src/collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ import { HIDDEN_COMMANDS } from '@mongosh/history';
import PlanCache from './plan-cache';
import ChangeStreamCursor from './change-stream-cursor';
import { ShellApiErrors } from './error-codes';
import type * as mql from '@mongodb-js/mql-typescript/schema';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I'm changing the moduleResolution ts compiler option. I want to be able to import a separate export from the default one.


export type CollectionWithSchema<
M extends GenericServerSideSchema = GenericServerSideSchema,
Expand Down Expand Up @@ -476,7 +477,7 @@ export class Collection<
@apiVersions([1])
@returnsPromise
async find(
query?: Document,
query?: mql.Query<C['schema']>,
projection?: Document,
options: FindOptions = {}
): Promise<Cursor> {
Expand Down
Loading