chore: pass --fix to the eslint command rather than npm #2495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the reformat npm script across all packages to ensure the --fix flag is passed to ESLint rather than npm itself.
- Adds an explicit
--delimiter before--fixin theeslintinvocation. - Applies this change uniformly to every package’s
package.json.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/types/package.json | Fix ESLint flag forwarding in reformat script |
| packages/snippet-manager/package.json | Fix ESLint flag forwarding in reformat script |
| packages/shell-evaluator/package.json | Fix ESLint flag forwarding in reformat script |
| packages/shell-api/package.json | Fix ESLint flag forwarding in reformat script |
| packages/service-provider-node-driver/package.json | Fix ESLint flag forwarding in reformat script |
| packages/service-provider-core/package.json | Fix ESLint flag forwarding in reformat script |
| packages/node-runtime-worker-thread/package.json | Fix ESLint flag forwarding in reformat script |
| packages/logging/package.json | Fix ESLint flag forwarding in reformat script |
| packages/js-multiline-to-singleline/package.json | Fix ESLint flag forwarding in reformat script |
| packages/i18n/package.json | Fix ESLint flag forwarding in reformat script |
| packages/history/package.json | Fix ESLint flag forwarding in reformat script |
| packages/errors/package.json | Fix ESLint flag forwarding in reformat script |
| packages/editor/package.json | Fix ESLint flag forwarding in reformat script |
| packages/e2e-tests/package.json | Fix ESLint flag forwarding in reformat script |
| packages/cli-repl/package.json | Fix ESLint flag forwarding in reformat script |
| packages/build/package.json | Fix ESLint flag forwarding in reformat script |
| packages/browser-runtime-electron/package.json | Fix ESLint flag forwarding in reformat script |
| packages/browser-runtime-core/package.json | Fix ESLint flag forwarding in reformat script |
| packages/browser-repl/package.json | Fix ESLint flag forwarding in reformat script |
| packages/autocomplete/package.json | Fix ESLint flag forwarding in reformat script |
| packages/async-rewriter2/package.json | Fix ESLint flag forwarding in reformat script |
addaleax
approved these changes
Jul 3, 2025
nirinchev
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we're not passing the
--fixoption to eslint correctly.