fix(build): create homebrew PRs against main
#2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default base branch for Homebrew PRs from master to main when publishing formula changes.
- Swaps the
createPullRequestbase argument from'master'to'main'. - Removes ESLint disable comments around template expressions.
Comments suppressed due to low confidence (1)
packages/build/src/homebrew/publish-to-homebrew.ts:79
- The ESLint disable comment for restrictive template expressions was removed but the interpolated values remain. This may trigger
@typescript-eslint/restrict-template-expressionserrors. Consider re-adding the disable comment or explicitly converting values to strings before interpolation.
`${homebrewCoreFork.repo.owner}:${forkBranch}`,
lerouxb
approved these changes
Jul 4, 2025
gagik
approved these changes
Jul 4, 2025
addaleax
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: Homebrew/homebrew-core#228993