fix(logging): forward debug logs #2528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we lose debug logging information from the oidc-plugin internals, such as HTTP request tracking.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
addaleax
added
the
no-title-validation
There was a problem hiding this comment.
Pull Request Overview
This PR enables debug logging to be forwarded from the oidc-plugin internals by updating the logging configuration and dependencies. The main purpose is to ensure that HTTP request tracking and other debug information from OIDC authentication flows are captured in the logging output.
- Adds debug log forwarding in the logging hook to capture debug-level information
- Updates devtools-connect and devtools-proxy-support dependencies to versions that support this functionality
- Includes a test to verify that OIDC HTTP calls are properly logged
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/logging/src/logging-and-telemetry.ts | Adds debug log forwarding to the hookLogger configuration |
| packages/e2e-tests/test/e2e-oidc.spec.ts | Adds test to verify OIDC HTTP request logging functionality |
| packages/types/package.json | Updates @mongodb-js/devtools-connect dependency to v3.9.4 |
| packages/snippet-manager/package.json | Updates @mongodb-js/devtools-proxy-support dependency to v0.5.3 |
| packages/service-provider-node-driver/package.json | Updates @mongodb-js/devtools-connect dependency to v3.9.4 |
| packages/logging/package.json | Updates @mongodb-js/devtools-connect dependency to v3.9.4 |
| packages/cli-repl/package.json | Updates @mongodb-js/devtools-proxy-support dependency to v0.5.3 |
| packages/arg-parser/package.json | Updates @mongodb-js/devtools-connect dependency to v3.9.4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gagik
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we lose debug logging information from the oidc-plugin internals, such as HTTP request tracking.
(requires mongodb-js/devtools-shared#570 to compile)