Skip to content

Conversation

@addaleax
Copy link
Collaborator

No description provided.

@addaleax addaleax requested a review from a team as a code owner November 27, 2025 14:46
Copilot AI review requested due to automatic review settings November 27, 2025 14:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the zod validation library from version 3.x to 4.x in the snippet-manager package. The upgrade includes updating the dependency version and adjusting test expectations to match zod 4.x's new error message format.

Key Changes:

  • Updated zod dependency from ^3.24.1 to ^4.1.13
  • Updated test assertion to reflect zod 4.x's new error message format for numeric validation

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/snippet-manager/package.json Updated zod dependency version to 4.1.13
packages/snippet-manager/src/snippet-manager.spec.ts Updated test expectation to match new zod 4.x error message format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 27, 2025
@gagik
Copy link
Contributor

gagik commented Nov 27, 2025

Would be better to target MCP protocol SDK's ^3.25.76 version. They backport v4 features so we can make use of them even then.

@addaleax
Copy link
Collaborator Author

@gagik No strong feelings here – we can close this, was only doing this because of #2589 🙂

@addaleax addaleax closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants