Skip to content

Conversation

@addaleax
Copy link
Collaborator

@addaleax addaleax commented Dec 1, 2025

These have occasionally been flaking with timeouts, which seems reasonable for downloading large blobs in CI.

These have occasionally been flaking with timeouts, which seems
reasonable for downloading large blobs in CI.
Copilot AI review requested due to automatic review settings December 1, 2025 15:17
@addaleax addaleax requested a review from a team as a code owner December 1, 2025 15:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the timeout for the before hook in the FLE (Field Level Encryption) end-to-end tests to prevent flaky test failures during CI runs. The timeout is extended from the default to 120 seconds specifically to accommodate the time required to download the crypt_shared library, which can be slow in CI environments.

  • Extended timeout to 120 seconds (120,000ms) for the before hook in FLE tests
  • Added explanatory comment documenting the reason for the extended timeout

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Dec 1, 2025
@addaleax addaleax merged commit 41fd911 into main Dec 3, 2025
154 of 157 checks passed
@addaleax addaleax deleted the fle-download-timeout branch December 3, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants