feat(shell-bson): add legacy uuid helpers MONGOSH-2486 #2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds three new legacy UUID helper functions (LegacyJavaUUID, LegacyCSharpUUID, and LegacyPythonUUID) to the shell-bson package for handling legacy UUID formats with BSON subtype 3. Each helper implements language-specific byte-swapping logic to match how Java, C#, and Python historically encoded UUIDs.
Key changes:
- Implementation of three legacy UUID helpers with language-specific byte ordering
- Comprehensive test coverage for each helper including byte-swapping verification
- E2E tests confirming the helpers print as
Binary.createFromBase64()with subtype 3
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/shell-bson/src/shell-bson.ts | Adds type definitions and implementations for the three legacy UUID helper functions |
| packages/shell-bson/src/shell-bson.spec.ts | Adds comprehensive unit tests for each legacy UUID helper and comparison tests |
| packages/e2e-tests/test/e2e-bson.spec.ts | Adds e2e tests for legacy UUID printing behavior and updates existing UUID test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
addaleax
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOSH-2486
Adds the
LegacyCSharpUUID,LegacyJavaUUID, andLegacyPythonUUIDhelpers to our shell bson package. We aren't adding a print for the subtype 3, as it could be any of them, so they are printed asBinary.createFromBase64(VALUE, 3).Added in devtools-shared in mongodb-js/devtools-shared#594