Skip to content

chore: fix auxiliary publishing for @aws-sdk/client-sts #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gagik merged 2 commits into from
Dec 3, 2025
Merged

chore: fix auxiliary publishing for @aws-sdk/client-sts #2610

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
623cd73
chore: client-sts
gagik Dec 3, 2025
c041b8a
add todo comment
gagik Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/node-runtime-worker-thread/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const config = {
interruptor: 'commonjs2 interruptor',
'os-dns-native': 'commonjs2 os-dns-native',
'system-ca': 'commonjs2 system-ca',
// @aws-sdk/client-sts is an optional peer dependency of @aws-sdk/credential-providers
'@aws-sdk/client-sts': 'commonjs2 @aws-sdk/client-sts',
Copy link
Collaborator

@addaleax addaleax Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm ... maybe a TODO ticket to clean this up?

But I don't think we should just make this a webpack external because it doesn't happen to get installed in CI. For Evergreen, we have a script (scripts/mark-ci-required-optional-dependencies.ts) to actually mark the "required optional" dependencies as required because we know we want them in CI (just not necessarily on user machines when they run e.g. npx mongosh). Maybe a similar approach makes sense here?

As part of the Node.js 24 upgrade project, we'll need to take care of making the @aws-sdk/credential-providers package a hard dependency of service-provider-node-driver, so this may change as part of that (I don't quite know how), hence the suggestion of a TODO ticket rather than doing something right now

},
};

Expand Down
Loading