chore: use knip for dependency checking #2613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR migrates from the deprecated depcheck tool to knip for dependency checking in the monorepo. The migration includes:
- Replacing
depcheckwithknipacross all packages - Adding comprehensive
knipconfiguration for the monorepo and individual packages - Bumping
mochaandsinonversions to ensure single hoisted instances - Reorganizing some dependencies from production to development sections
Reviewed changes
Copilot reviewed 56 out of 60 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds knip, removes depcheck, updates root-level depcheck script, upgrades mocha and sinon |
| knip.ts | Adds comprehensive knip configuration for monorepo workspace structure |
| .knipignore | Adds patterns to exclude from knip analysis |
| mongosh.code-workspace | Reorders java-shell workspace entry (dependency order) |
| packages/*/package.json | Removes depcheck script and dependency from all packages |
| packages/*/.depcheckrc | Removes deprecated depcheck config files |
| packages/shell-api/tsconfig-lint.json | Updates include path from bin to scripts |
| packages/shell-api/scripts/*.ts | Updates import paths from '../' to '../lib' |
| packages/shell-api/package.json | Moves @babel packages to devDependencies, updates script paths from bin to scripts |
| packages/async-rewriter2/package.json | Updates script path from bin to scripts |
| packages/browser-repl/package.json | Adds webpack-serve script, removes unused type dependencies |
| packages/node-runtime-worker-thread/package.json | Moves web-worker to devDependencies, upgrades mocha |
| packages/autocomplete/package.json | Upgrades mocha version |
| packages/logging/package.json | Moves @mongosh/errors to devDependencies |
| packages/e2e-tests/package.json | Moves runtime dependencies to devDependencies |
| packages/e2e-tests/test/e2e.spec.ts | Updates require path from dependencies to devDependencies |
| packages/browser-runtime-electron/package.json | Removes unused @types dependencies |
| packages/browser-runtime-electron/src/electron-runtime.spec.ts | Updates sinon stub creation pattern |
| packages/java-shell/package.json | Adds @mongosh/testing as devDependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
force-pushed
the
gagik/adopt-knip
branch
from
147f7d0 to
f4bf9ba
Compare
gagik
added
the
no-title-validation
addaleax
reviewed
Dec 5, 2025
gagik
force-pushed
the
gagik/adopt-knip
branch
from
7ab8453 to
ba93a57
Compare
gagik
force-pushed
the
gagik/adopt-knip
branch
2 times, most recently
from
fdeeb03 to
7d15df4
Compare
gagik
commented
Dec 5, 2025
| messageBus = sinon.createStubInstance(EventEmitter); | ||
| evaluationListener = sinon.createStubInstance(class FakeListener {}); | ||
| evaluationListener.onPrint = sinon.stub(); | ||
| evaluationListener = { |
Contributor
Author
There was a problem hiding this comment.
necessary because of sinon bump
gagik
force-pushed
the
gagik/adopt-knip
branch
from
7d15df4 to
a4c2d77
Compare
addaleax
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depcheck is deprecated and knip has some nice extra such as webpack and mocha integration.
Also bumps mocha and sinon to ensure we have 1 hoisted entry.