Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .evergreen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ functions:
set -e
set -x

export NODE_VERSION=16.19.0
export NODE_VERSION=22.15.1
bash .evergreen/install-node.sh
install:
- command: shell.exec
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,20 @@ name: CI
jobs:
test:
name: Test
timeout-minutes: 10
Copy link
Member Author

@Anemy Anemy Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these tests don't cleanup fully. To prevent them running 360 minutes I'm adding this. Not fixing the root in these changes, likely that'll be saved for another time.

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [16.x, 18.x, 20.x]
node-version: [22.x, 24.x]
runs-on: ${{matrix.os}}
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
# the oidc-provider package we use doesn't list Node.js 20 as supported
# the oidc-provider package we use doesn't list Node.js 22 and 24 as supported
- name: Install Dependencies
run: npm ci --ignore-engines
- name: Test
Expand All @@ -34,7 +35,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: [18.x]
node-version: [22.x]
runs-on: ${{matrix.os}}
steps:
- uses: actions/checkout@v4
Expand All @@ -56,10 +57,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Use Node.js 20.x
- name: Use Node.js 22.x
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 22.x

- name: Install Dependencies
run: npm ci --ignore-engines
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:

- uses: actions/checkout@v4

- name: Use Node.js 20.x
- name: Use Node.js 22.x
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 22.x
registry-url: 'https://registry.npmjs.org'

- name: Install Dependencies
Expand Down
6 changes: 6 additions & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# This file is for the version management tool "asdf".
# mms uses it as well.

# This Node.js version matches the one required in
# the "engines" in the package.json and .everygreen.yml
nodejs 22.15.1
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"import": "./dist/.esm-wrapper.mjs"
},
"engines": {
"node": ">= 16.20.1"
"node": ">= 22.15.1"
},
"types": "./index.d.ts",
"scripts": {
Expand Down
6 changes: 5 additions & 1 deletion test/oidc-test-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,11 @@ async function spawnBrowser(
...options.capabilities,
'goog:chromeOptions': {
binary: electronPath,
args: [`--app=${url}`, '--'],
args: [`--app=${url}`, '--disable-save-password-bubble', '--'],
prefs: {
'profile.password_manager_enabled': false,
credentials_enable_service: false,
},
},
},
});
Expand Down
Loading