fix: add cause error messages also on generic token parse failures MONGOSH-2884
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
cause error messages also on generic token parse failurescause error messages also on generic token parse failures MONGOSH-2884
nbbeeken
approved these changes
Oct 6, 2025
Comment on lines
+1727
to
+1729
| expect(err.message).to.equal( | ||
| 'invalid response encountered (caused by: JWT "nonce" (nonce) claim missing)' | ||
| ); |
There was a problem hiding this comment.
Should this be checking for "cause" to be defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, error messages are short and potentially not very helpful. We already implemented this for HTTP errors earlier in 4f69e53 and improved on it in cb07f51, but did not account for these specific types of very broad generic failures.