chore: adds vscode specific connection error handler MCP-132 #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
approved these changes
Sep 3, 2025
Comment on lines
+8
to
+11
| connectionController: Pick< | ||
| ConnectionController, | ||
| 'getSavedConnections' | 'getActiveConnectionName' | ||
| >, |
There was a problem hiding this comment.
Why the pick here - why not just get the complete controller?
There was a problem hiding this comment.
Because the code does not really depend on anything more than the required methods and the consuming side shouldn't have to be bound to pass anything more than the required methods?
Base automatically changed from
chore/MCP-131-vscode-connection-manager
to
feat/mcp-integration
September 3, 2025 12:16
himanshusinghs
force-pushed
the
chore/MCP-132-vscode-connection-error-handler
branch
from
69a8b0c to
5ef220b
Compare
himanshusinghs
deleted the
chore/MCP-132-vscode-connection-error-handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we're introducing a VSCode specific connection error handler to handle connection related errors and provide VSCode specific guidance on how to resolve them.
This depends on error handler interface PR in mongodb-mcp-server.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes