chore: reorganise GA to check and build once and run tests with matrix strategy VSCODE-703 #1133
+439
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier snyk was never scanning the vscode project because of the combination of project auto-detection and the presence of .vscode-test folder which contains several directories with package.json files. This commit disables the auto-detection so that snyk run tests on the current project. Additionally the current project was having a problem with a package declaring optional dependencies. These optional dependencies were platform specific so for any platform, all the optional dependencies will never be installed, only the ones that are platform compatible. Snyk requires what is declared in package-lock.json to be also present in node_modules folder which is why it would've failed. In the same commit, we added a pre and post test hook to remove the identified problematic optional dependencies from package-lock file before running the test and then restore it when the test is finished.
Earlier we were running check, build and tests on each OS in our matrix which did not allow us to test whether a build on ubuntu would work fine on Windows / MacOS or not. With this commit we are re-organising to check and build once on ubuntu and use the final artifact later in the test job to run tests against. Accordingly the test-and-build-from-fork and draft-release workflows have been modified to adapt the same change.
himanshusinghs
force-pushed
the
chore/gh-actions-reorg-for-install-tests
branch
from
dedcaad to
de36329
Compare
himanshusinghs
commented
Nov 25, 2025
Contributor
Author
himanshusinghs
left a comment
himanshusinghs
left a comment
There was a problem hiding this comment.
I am unable to approve (as author) but looks good to me 👍. I added a small question for clarification.
Comment on lines
+82
to
+99
| status-check: | ||
| name: Test and Build | ||
| runs-on: ubuntu-latest | ||
| needs: [build-and-package, test] | ||
| if: always() | ||
| steps: | ||
| - name: Check job results | ||
| run: | | ||
| if [ "${{ needs.build-and-package.result }}" == "failure" ] || [ "${{ needs.test.result }}" == "failure" ]; then | ||
| echo "One or more jobs failed" | ||
| exit 1 | ||
| elif [ "${{ needs.build-and-package.result }}" == "cancelled" ] || [ "${{ needs.test.result }}" == "cancelled" ]; then | ||
| echo "One or more jobs were cancelled" | ||
| exit 1 | ||
| else | ||
| echo "All jobs completed successfully or were skipped" | ||
| exit 0 | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
Curious about this, why was this needed?
Contributor
There was a problem hiding this comment.
It was hanging without this. Perhaps there's a more elegant solution, but its not just AI slop. 😅
gagik
reviewed
Nov 27, 2025
| name: Test and Build | ||
| runs-on: ubuntu-latest | ||
| needs: [build-and-package, test] | ||
| if: always() |
Contributor
There was a problem hiding this comment.
it was hanging, when running a normal build, this would start but never resolve, so the checks never passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier we were running check, build and tests on each OS in our matrix which did not allow us to test whether a build on ubuntu would work fine on Windows / MacOS or not.
With this commit we are re-organising to check and build once on ubuntu and use the final artifact later in the test job to run tests against.
Accordingly the test-and-build-from-fork and draft-release workflows have been modified to adapt the same change.
This PR simply re-organise the existing actions and does not introduce any install tests just yet. That will come in a different PR.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes