Skip to content

fix(NODE-6381): use targeting for x86_64 darwin #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2024
Merged

fix(NODE-6381): use targeting for x86_64 darwin #26

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f20bd65
fix: use targeting for x64 darwin
durran Sep 13, 2024
59ee8ee
fix: move to download artifact v4
durran Sep 13, 2024
e7eaa58
fix: use same version of upload artifact
durran Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
target: x86_64-apple-darwin
architecture: x64
build: |
npm run build
npm run build -- --target x86_64-apple-darwin
strip -x *.node
- host: windows-latest
build: npm run build
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
if: ${{ !matrix.settings.docker }}
shell: bash
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bindings-${{ matrix.settings.target }}
path: ${{ env.APP_NAME }}.*.node
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
- name: Install dependencies
run: npm clean-install --ignore-scripts
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-${{ matrix.settings.target }}
path: .
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
- name: Install dependencies
run: npm clean-install --ignore-scripts
- name: Download artifacts
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: bindings-x86_64-unknown-linux-gnu
path: .
Expand Down Expand Up @@ -248,7 +248,7 @@ jobs:
- name: Install dependencies
run: npm clean-install --ignore-scripts
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-x86_64-unknown-linux-musl
path: .
Expand All @@ -275,7 +275,7 @@ jobs:
- run: docker run --rm --privileged multiarch/qemu-user-static:register --reset
- uses: actions/checkout@v3
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-aarch64-unknown-linux-gnu
path: .
Expand Down Expand Up @@ -313,7 +313,7 @@ jobs:
- run: docker run --rm --privileged multiarch/qemu-user-static:register --reset
- uses: actions/checkout@v3
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-aarch64-unknown-linux-musl
path: .
Expand Down Expand Up @@ -363,7 +363,7 @@ jobs:
- name: Install dependencies
run: npm clean-install --ignore-scripts
- name: Download all artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts
- name: Move artifacts
Expand Down
Loading