Skip to content

fix: bundle release build on windows #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024
Merged

fix: bundle release build on windows #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa5ae35
objdump
baileympearson Dec 5, 2024
0a9568a
add grep
baileympearson Dec 5, 2024
ee7e0a9
Update etc/install-zstd.sh
baileympearson Dec 5, 2024
6565172
non-debug release windows
baileympearson Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
{
'link_settings': {
'libraries': [
'<(module_root_dir)/deps/zstd/out/lib/Debug/zstd_static.lib'
'<(module_root_dir)/deps/zstd/out/lib/Release/zstd_static.lib'
]
},
},
Expand Down
2 changes: 1 addition & 1 deletion etc/install-zstd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ build_zstd() {
-DCMAKE_BUILD_TYPE=Release \
../build/cmake

cmake --build . --target libzstd_static
cmake --build . --target libzstd_static --config Release
}

clean_deps
Expand Down
Loading