Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Jun 24, 2025

Description

Drops support for Node 16 and 18

What is changing?

  • Updates Node 16 CI tasks to run on Node 20, 22, 24.
  • Fixes the windows 2019 blackout issue on actions.
Is there new documentation needed for these changes?

Manual updates for supported versions.

What is the motivation for this change?

NODE-7007

Double check the following

  • Ran npm run format:js && npm run format:rs script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review June 24, 2025 13:44
@durran durran requested a review from a team as a code owner June 24, 2025 13:44
@durran durran marked this pull request as draft June 24, 2025 14:31
@durran durran marked this pull request as ready for review September 10, 2025 14:20
@baileympearson baileympearson changed the title feat(NODE-7007): remove support for node 16 and 18 feat!(NODE-7007): remove support for node 16 and 18 Sep 10, 2025
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot comment on the following because they're out-of-diff:

  • can we audit our dependabot config for any packages we can now update because we no longer support Node16 and 18?
  • Can we update the readme's compat table with accurate glibc requirements (if they have changed), now that we're Node 20+?

@nbbeeken nbbeeken changed the title feat!(NODE-7007): remove support for node 16 and 18 feat(NODE-7007)!: remove support for node 16 and 18 Sep 10, 2025
@nbbeeken
Copy link
Contributor

This happened last time we did a major, double check the ! is in the right position 😅 next to the :

@durran durran changed the title feat(NODE-7007)!: remove support for node 16 and 18 feat(NODE-7007):! remove support for node 16 and 18 Sep 11, 2025
@durran durran changed the title feat(NODE-7007):! remove support for node 16 and 18 feat(NODE-7007)!: remove support for node 16 and 18 Sep 11, 2025
@durran
Copy link
Member Author

durran commented Sep 11, 2025

This happened last time we did a major, double check the ! is in the right position 😅 next to the :

👍

Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional changes I cannot comment on because they're out-of-diff:

  • There are more occurrences of Node16 in the build action that should be updated
  • There's logic to set ubuntu_version in our yml files that can go away (UBUNTU_VERSION can probably be removed entirely as an argument to the dockerfile too)
  • can we audit our dependabot config for any packages we can now update because we no longer support Node16 and 18?
  • Can we update the readme's compat table with accurate glibc requirements (if they have changed), now that we're Node 20+?

@durran
Copy link
Member Author

durran commented Sep 12, 2025

Some additional changes I cannot comment on because they're out-of-diff:

* There are more occurrences of Node16 in the build action that should be updated

* There's logic to set `ubuntu_version` in our yml files that can go away (UBUNTU_VERSION can probably be removed entirely as an argument to the dockerfile too)

* can we audit our dependabot config for any packages we can now update because we no longer support Node16 and 18?

* Can we update the readme's compat table with accurate glibc requirements (if they have changed), now that we're Node 20+?

I've updated everything except UBUNTU_VERSION, since it was actually needed for the builds to run.

Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot comment because it isn't in the diff

  1. docker.sh still defaults to Node18. Can we update that to Node20 as well?
  2. I think we can update nyc now, and remove the exception from our dependabot config (nyc's next major version is Node18+, which is why we haven't upgraded)

@baileympearson
Copy link
Contributor

@durran Can we also increase our ecmascript target in the eslint config to 2023 (https://node.green/#ES2023)?

@durran
Copy link
Member Author

durran commented Sep 15, 2025

@durran Can we also increase our ecmascript target in the eslint config to 2023 (https://node.green/#ES2023)?

Done

@baileympearson baileympearson merged commit 9b8025f into main Sep 15, 2025
31 checks passed
@baileympearson baileympearson deleted the NODE-7007 branch September 15, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants