-
Notifications
You must be signed in to change notification settings - Fork 12
feat(NODE-7007)!: remove support for node 16 and 18 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot comment on the following because they're out-of-diff:
- can we audit our dependabot config for any packages we can now update because we no longer support Node16 and 18?
- Can we update the readme's compat table with accurate glibc requirements (if they have changed), now that we're Node 20+?
This happened last time we did a major, double check the |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional changes I cannot comment on because they're out-of-diff:
- There are more occurrences of Node16 in the build action that should be updated
- There's logic to set
ubuntu_version
in our yml files that can go away (UBUNTU_VERSION can probably be removed entirely as an argument to the dockerfile too) - can we audit our dependabot config for any packages we can now update because we no longer support Node16 and 18?
- Can we update the readme's compat table with accurate glibc requirements (if they have changed), now that we're Node 20+?
I've updated everything except UBUNTU_VERSION, since it was actually needed for the builds to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot comment because it isn't in the diff
docker.sh
still defaults to Node18. Can we update that to Node20 as well?- I think we can update
nyc
now, and remove the exception from our dependabot config (nyc's next major version is Node18+, which is why we haven't upgraded)
Co-authored-by: Bailey Pearson <[email protected]>
@durran Can we also increase our ecmascript target in the eslint config to 2023 (https://node.green/#ES2023)? |
Done |
Description
Drops support for Node 16 and 18
What is changing?
Is there new documentation needed for these changes?
Manual updates for supported versions.
What is the motivation for this change?
NODE-7007
Double check the following
npm run format:js && npm run format:rs
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript