Skip to content

Commit 17a6444

Browse files
committed
minimum implementation to have test failing because difference in golden file
1 parent 5dfbede commit 17a6444

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

internal/convert/convert.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,11 @@ func fillReplicationSpecs(resourceb *hclwrite.Body, root attrVals) error {
202202
break
203203
}
204204
specbSrc := specSrc.Body()
205-
if err := checkDynamicBlock(specbSrc); err != nil {
206-
return err
207-
}
208205
// ok to fail as zone_name is optional
209206
_ = hcl.MoveAttr(specbSrc, specb, nZoneName, nZoneName, errRepSpecs)
207+
if hasDynamicBlock, err := fillRegionConfigsDynamicBlock(specb, specbSrc, root); err != nil || hasDynamicBlock {
208+
return err
209+
}
210210
shards := specbSrc.GetAttribute(nNumShards)
211211
if shards == nil {
212212
return fmt.Errorf("%s: %s not found", errRepSpecs, nNumShards)
@@ -306,6 +306,14 @@ func fillBlockOpt(resourceb *hclwrite.Body, name string) {
306306
resourceb.SetAttributeRaw(name, hcl.TokensObject(block.Body()))
307307
}
308308

309+
func fillRegionConfigsDynamicBlock(specb, specbSrc *hclwrite.Body, root attrVals) (bool, error) {
310+
d, err := getDynamicBlock(specbSrc, nConfigSrc)
311+
if err != nil || d.forEach == nil {
312+
return false, err
313+
}
314+
return true, nil
315+
}
316+
309317
func fillRegionConfigs(specb, specbSrc *hclwrite.Body, root attrVals) error {
310318
var configs []*hclwrite.Body
311319
for {

0 commit comments

Comments
 (0)