-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Convert free clusters with count #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
return nil | ||
} | ||
|
||
func moveAttribute(fromAttrName, toAttrName string, fromBody, toBody *hclwrite.Body, errPrefix string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the abstraction signature and you don't need to worry about the type of the attribute!
labels[0] = advCluster | ||
resource.SetLabels(labels) | ||
|
||
if isFreeTier(resourceBody) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool approach of starting with one specific case.
I guess some operations might be more generally applicable, like moving instance_size, but we'll find out once we add more cases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'll go now with one with num_shards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
{ | ||
"configuration_file_error": "failed to parse Terraform config file", | ||
"free_cluster_missing_attribute": "free cluster (because no replication_specs): attribute backing_provider_name not found" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errors file instead of having individual out files with just the error message, so it's easier to have multiple input files with errors and don't have many files, and have a place to see all error messages.
Description
Convert free clusters with count
Link to any related issue(s): CLOUDP-297859
Type of change:
Required Checklist:
Further comments