Skip to content

Conversation

lantoli
Copy link
Collaborator

@lantoli lantoli commented Feb 7, 2025

Description

Convert clusters with 1 replication_spec and multiple region_configs. It also converts read_only_specs and analytics_specs, and detects if dynamic blocks are being used.

Link to any related issue(s): CLOUDP-299286

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the enhancement New feature or request label Feb 7, 2025
@lantoli lantoli marked this pull request as ready for review February 10, 2025 07:43
@lantoli lantoli requested a review from a team as a code owner February 10, 2025 07:43
Copy link
Contributor

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love to see all the test cases.

@lantoli lantoli merged commit 5e717b7 into main Feb 10, 2025
6 checks passed
@lantoli lantoli deleted the CLOUDP-299286_multiple_region_configs branch February 10, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants