feat: Convert tags, labels, timeouts, advanced_configuration, bi_connector_config and pinned_fcv #21
Conversation
| return ret | ||
| } | ||
|
|
||
| // RemoveLeadingNewline removes the first newline if it exists to make the output prettier. |
There was a problem hiding this comment.
e.g for timeouts, HC funcs don't delete the newline after the block is opened
| instance_size = "M10" | ||
| disk_size_gb = 100 | ||
| } | ||
| }, { |
There was a problem hiding this comment.
change format for arrays because TF formatting is not clear when arrays bracket are with the first/last object, the intermediate }, { is not indented correctly.
This format takes a few more lines but it's more clear, especially for long cluster definitions.
lantoli
changed the title
| } | ||
| fillBlockOpt(resourceb, nTimeouts) | ||
| fillBlockOpt(resourceb, nAdvConf) | ||
| fillBlockOpt(resourceb, nBiConnector) |
There was a problem hiding this comment.
love this 1 line additions
| ] | ||
| tags = { | ||
| environment = "dev" | ||
| (var.tag_key) = var.tag_value |
| pinned_fcv { | ||
| # comments in pinned_fcv are kept | ||
| expiration_date = var.fcv_date | ||
| version = var.fcv_date | ||
| } |
There was a problem hiding this comment.
nit: version is a computed-only attribute in both cluster and advanced_cluster so no need to handle it
There was a problem hiding this comment.
ah, thanks, we're just moving the block entirely, but will remove the version attribute in a follow-up PR so the example is more real
There was a problem hiding this comment.
@lantoli nit: it's preferable to comment the code and create a CLOUDP to help everyone giving confidence we don't forget this
| provider_name = "AWS" | ||
| provider_instance_size_name = "M10" | ||
| replication_specs { | ||
| num_shards = 1 |
There was a problem hiding this comment.
question not related to PR, how will we handle num_shards > 1? Will we have logic in the conversion to define multiple replication specs?
There was a problem hiding this comment.
to be honest, i haven't thought about it yet, but I guess it'll be in the func creating the replication_specs, that will create multiple ones
4 participants
Description
Convert tags, labels, timeouts, advanced_configuration, bi_connector_config and pinned_fcv.
It also improves arrays formatting.
Link to any related issue(s): CLOUDP-299725
Type of change:
Required Checklist:
Further comments